mirror of
https://github.com/ForkAwesome/Fork-Awesome.git
synced 2024-12-25 13:01:31 +08:00
add note about linking pull requests to issues
if pull request creators are considerate enough to follow this, it could save the maintainers a lot of time in triaging issues to be closed after they have already been merged into the icon set
This commit is contained in:
parent
964d92e199
commit
de0289499c
@ -28,6 +28,13 @@ Adding a new icon is a couple steps process that will require your attention and
|
|||||||
5. Once you are satisfied with your design and the preview of it. Add the icon name, unicode point and icon information at the bottom of the `src/icons/icons.yml` file. Look at other entries to see how it's done and to give it a proper classification.
|
5. Once you are satisfied with your design and the preview of it. Add the icon name, unicode point and icon information at the bottom of the `src/icons/icons.yml` file. Look at other entries to see how it's done and to give it a proper classification.
|
||||||
6. Once all this is done, commit your changes and make a pull request.
|
6. Once all this is done, commit your changes and make a pull request.
|
||||||
|
|
||||||
|
Note : Please be considerate about maintainers' time and please
|
||||||
|
[link your pull requests] to the icon request issue if it exists. You
|
||||||
|
could use it within your commit message as well. This saves the
|
||||||
|
maintainers extra effort in having to keep track of and close completed
|
||||||
|
issues.
|
||||||
|
|
||||||
|
[link your pull requests]: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
|
||||||
|
|
||||||
## Suggesting icon keyword addition/removal
|
## Suggesting icon keyword addition/removal
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user